Re: [PATCH] mm/swapops: make is_pmd_migration_entry more strict

From: Peter Xu
Date: Fri Apr 29 2022 - 09:31:13 EST


On Fri, Apr 29, 2022 at 10:23:08AM +0800, Hongchen Zhang wrote:
> Hello Peter,

Hi, Hongchen,

> (1) the pmd passed to __split_huge_pmd_locked may be a none pmd,so it may
> be wrongly treated as a pmd migration entry.

With !ARCH_ENABLE_THP_MIGRATION is_pmd_migration_entry() returns 0
constantly.

> (2) we are preparing to support thp migration on MIPS.

Makes sense (to not have Fixes then). It'll be great if the objective of
the patch will be mentioned in the future.

Thanks for answering!

--
Peter Xu