Re: [PATCH] firmware: xilinx: add support for sd/usb/gem config

[Michal Simek]

On 4/29/22 12:16, Ronak Jain wrote:
> Add new APIs in firmware to configure SD/GEM/USB registers. Internally
> it calls PM IOCTL for below SD/GEM/USB register configuration:
> - SD/EMMC select
> - SD slot type
> - SD base clock
> - SD 8 bit support
> - GEM SGMII Mode
> - SD fixed config
> - GEM fixed config
> - USB fixed config
>
> Signed-off-by: Ronak Jain <ronak.jain@xxxxxxxxxx>

I think it was said that you shouldn't send interface changes without any user.
It means every function you add should be also used.

Thanks,
Michal