Re: [PATCH] [v2] plfxlc: fix le16_to_cpu warning for beacon_interval

[Johannes Berg]

On Fri, 2022-04-29 at 10:44 +0000, Srinivasan Raju wrote:
> Fix the following sparse warnings:
> 
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Srinivasan Raju <srini.raju@xxxxxxxxxxxx>
> ---
>  drivers/net/wireless/purelifi/plfxlc/chip.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/purelifi/plfxlc/chip.c b/drivers/net/wireless/purelifi/plfxlc/chip.c
> index a5ec10b66ed5..79d187cf3715 100644
> --- a/drivers/net/wireless/purelifi/plfxlc/chip.c
> +++ b/drivers/net/wireless/purelifi/plfxlc/chip.c
> @@ -29,11 +29,10 @@ int plfxlc_set_beacon_interval(struct plfxlc_chip *chip, u16 interval,
>                                u8 dtim_period, int type)
>  {
>         if (!interval ||
> -           (chip->beacon_set &&
> -            le16_to_cpu(chip->beacon_interval) == interval))
> +           (chip->beacon_set && chip->beacon_interval) == interval)
> 

I think you got the parentheses wrong.

johannes