Re: [PATCH] arch/mips/kernel/traps: add CONFIG_MIPS_FP_SUPPORT when using handle_fpe

From: Stephen Zhang
Date: Thu Apr 28 2022 - 23:11:11 EST


Maciej W. Rozycki <macro@xxxxxxxxxxx> 于2022年4月28日周四 17:00写道:
>
> On Thu, 28 Apr 2022, Stephen Zhang wrote:
> Thanks.
>
> The bug is in arch/mips/include/asm/mach-ip27/cpu-feature-overrides.h,
> which has:
>
> #define cpu_has_fpu 1
>
> (and similarly arch/mips/include/asm/mach-ip30/cpu-feature-overrides.h).
> This is not supported, as noted in arch/mips/include/asm/cpu-features.h:
>
> /* Don't override `cpu_has_fpu' to 1 or the "nofpu" option won't work. */
>
> Perhaps we should explicitly undefine `cpu_has_fpu' if set to 1?
>
> Maciej

Thanks for your detailed explanation and suggestion. I will make a v2 patch.