Re: [PATCH net-next 0/2] net: lan966x: remove PHY reset support

From: Horatiu Vultur
Date: Thu Apr 28 2022 - 16:34:30 EST


The 04/28/2022 13:40, Michael Walle wrote:
>
> Remove the unneeded PHY reset node as well as the driver support for it.
>
> This was already discussed [1] and I expect Microchip to Ack on this
> removal. Since there is no user, no breakage is expected.

This looks good to me:
Acked-by: Horatiu Vultur <horatiu.vultur@xxxxxxxxxxxxx>

>
> I'm not sure it this should go through net or net-next and if the patches
> should have a Fixes: tag or not. In upstream linux there was never any user
> of it, so there is no bug to be fixed. But OTOH if the schema fix isn't
> backported, then there might be an older schema version still containing
> the reset node. Thoughts?
>
> The patches needed for the GPIO part are just waiting to be picked up by
> Linus [2,3]. This patch and the GPIO parts are the last pieces of the
> puzzle to get ethernet working on the LAN9668 on upstream linux.
>
> [1] https://lore.kernel.org/netdev/20220330110210.3374165-1-michael@xxxxxxxx/
> [2] https://lore.kernel.org/linux-gpio/CACRpkdbxmN+SWt95aGHjA2ZGnN61aWaA7c5S4PaG+WePAj=htg@xxxxxxxxxxxxxx/
> [3] https://lore.kernel.org/linux-gpio/20220420191926.3411830-1-michael@xxxxxxxx/
>
> Michael Walle (2):
> dt-bindings: net: lan966x: remove PHY reset
> net: lan966x: remove PHY reset support
>
> .../devicetree/bindings/net/microchip,lan966x-switch.yaml | 2 --
> drivers/net/ethernet/microchip/lan966x/lan966x_main.c | 8 +-------
> 2 files changed, 1 insertion(+), 9 deletions(-)
>
> --
> 2.30.2
>

--
/Horatiu