[ammarfaizi2-block:kvalo/ath/pending 7/57] drivers/net/wireless/realtek/rtw89/ser.c:319:2: warning: unannotated fall-through between switch labels

From: kernel test robot
Date: Thu Apr 28 2022 - 13:47:56 EST


Hi Zong-Zhe,

FYI, the error/warning still remains.

tree: https://github.com/ammarfaizi2/linux-block kvalo/ath/pending
head: 5c6cf64b40b98e4d4247fda11e4b4c859a24585d
commit: 14f9f4790048f684c2b151c899895feae0b5731a [7/57] rtw89: ser: control hci interrupts on/off by state
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220429/202204290113.w78dhtXk-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c59473aacce38cd7dd77eebceaf3c98c5707ab3b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/ammarfaizi2/linux-block/commit/14f9f4790048f684c2b151c899895feae0b5731a
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block kvalo/ath/pending
git checkout 14f9f4790048f684c2b151c899895feae0b5731a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/misc/lkdtm/ drivers/net/wireless/realtek/rtw89/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/realtek/rtw89/ser.c:319:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
default:
^
drivers/net/wireless/realtek/rtw89/ser.c:319:2: note: insert 'break;' to avoid fall-through
default:
^
break;
1 warning generated.


vim +319 drivers/net/wireless/realtek/rtw89/ser.c

e3ec7017f6a20d Ping-Ke Shih 2021-10-11 301
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 302 /* state handler */
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 303 static void ser_idle_st_hdl(struct rtw89_ser *ser, u8 evt)
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 304 {
14f9f4790048f6 Zong-Zhe Yang 2022-03-14 305 struct rtw89_dev *rtwdev = container_of(ser, struct rtw89_dev, ser);
14f9f4790048f6 Zong-Zhe Yang 2022-03-14 306
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 307 switch (evt) {
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 308 case SER_EV_STATE_IN:
14f9f4790048f6 Zong-Zhe Yang 2022-03-14 309 rtw89_hci_recovery_complete(rtwdev);
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 310 break;
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 311 case SER_EV_L1_RESET:
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 312 ser_state_goto(ser, SER_RESET_TRX_ST);
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 313 break;
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 314 case SER_EV_L2_RESET:
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 315 ser_state_goto(ser, SER_L2_RESET_ST);
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 316 break;
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 317 case SER_EV_STATE_OUT:
14f9f4790048f6 Zong-Zhe Yang 2022-03-14 318 rtw89_hci_recovery_start(rtwdev);
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 @319 default:
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 320 break;
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 321 }
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 322 }
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 323

:::::: The code at line 319 was first introduced by commit
:::::: e3ec7017f6a20d12ddd9fe23d345ebb7b8c104dd rtw89: add Realtek 802.11ax driver

:::::: TO: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
:::::: CC: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

--
0-DAY CI Kernel Test Service
https://01.org/lkp