Re: [PATCH 1/2] seccomp: Use FIFO semantics to order notifications

From: Christian Brauner
Date: Thu Apr 28 2022 - 04:04:59 EST


On Wed, Apr 27, 2022 at 06:54:46PM -0700, Sargun Dhillon wrote:
> Previously, the seccomp notifier used LIFO semantics, where each
> notification would be added on top of the stack, and notifications
> were popped off the top of the stack. This could result one process
> that generates a large number of notifications preventing other
> notifications from being handled. This patch moves from LIFO (stack)
> semantics to FIFO (queue semantics).
>
> Signed-off-by: Sargun Dhillon <sargun@xxxxxxxxx>
> ---

It has a minimal user-visible impact in a sense but I don't think it
should be an issue. Makes sense to me,
Reviewed-by: Christian Brauner (Microsoft) <brauner@xxxxxxxxxx>