Re: [PATCH v2 02/12] md/raid5: Refactor raid5_make_request loop

From: Guoqing Jiang
Date: Wed Apr 27 2022 - 21:17:04 EST




On 4/28/22 12:08 AM, Logan Gunthorpe wrote:

+        if (unlikely(!sh)) {
+            /* cannot get stripe, just give-up */
+            bi->bi_status = BLK_STS_IOERR;
+            break;
+        }

Nit, I would suggest to keep below original comment.
But the original comment was plainly wrong...

I think it was for get stripe for read-ahead.

https://elixir.bootlin.com/linux/v5.18-rc4/source/drivers/md/raid5.c#L5869

And it deserves a separate change if you think the comment is wrong, but
just my $0.02.

Thanks,
Guoqing