RE: [PATCH 10/10] arm64: dts: fsd: use proper 'dma-channels/requests' properties

From: Alim Akhtar
Date: Wed Apr 27 2022 - 12:49:19 EST




>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxx]
>Sent: Wednesday, April 27, 2022 9:29 PM
>To: Lee Jones <lee.jones@xxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Alim Akhtar
><alim.akhtar@xxxxxxxxxxx>; Dinh Nguyen <dinguyen@xxxxxxxxxx>; Michal
>Simek <michal.simek@xxxxxxxxxx>; Liviu Dudau <liviu.dudau@xxxxxxx>;
>Sudeep Holla <sudeep.holla@xxxxxxx>; Lorenzo Pieralisi
><lorenzo.pieralisi@xxxxxxx>; Ray Jui <rjui@xxxxxxxxxxxx>; Scott Branden
><sbranden@xxxxxxxxxxxx>; Broadcom Kernel Team <bcm-kernel-feedback-
>list@xxxxxxxxxxxx>; Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>;
>devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>; Rob Herring
><robh@xxxxxxxxxx>
>Subject: [PATCH 10/10] arm64: dts: fsd: use proper 'dma-channels/requests'
>properties
>
>pl330 DMA controller bindings documented 'dma-channels' and 'dma-
>requests' properties (without leading hash sign), so fix the DTS to match
the
>bindings.
>
>Reported-by: Rob Herring <robh@xxxxxxxxxx>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>---

Acked-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> arch/arm64/boot/dts/tesla/fsd.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
>b/arch/arm64/boot/dts/tesla/fsd.dtsi
>index 10c217a57a7d..7fba37d860b2 100644
>--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
>+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
>@@ -432,8 +432,8 @@ mdma0: dma-controller@10100000 {
> reg = <0x0 0x10100000 0x0 0x1000>;
> interrupts = <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>;
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <32>;
>+ dma-channels = <8>;
>+ dma-requests = <32>;
> clocks = <&clock_imem
>IMEM_DMA0_IPCLKPORT_ACLK>;
> clock-names = "apb_pclk";
> iommus = <&smmu_imem 0x800 0x0>;
>@@ -444,8 +444,8 @@ mdma1: dma-controller@10110000 {
> reg = <0x0 0x10110000 0x0 0x1000>;
> interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <32>;
>+ dma-channels = <8>;
>+ dma-requests = <32>;
> clocks = <&clock_imem
>IMEM_DMA1_IPCLKPORT_ACLK>;
> clock-names = "apb_pclk";
> iommus = <&smmu_imem 0x801 0x0>;
>@@ -456,8 +456,8 @@ pdma0: dma-controller@14280000 {
> reg = <0x0 0x14280000 0x0 0x1000>;
> interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <32>;
>+ dma-channels = <8>;
>+ dma-requests = <32>;
> clocks = <&clock_peric
>PERIC_DMA0_IPCLKPORT_ACLK>;
> clock-names = "apb_pclk";
> iommus = <&smmu_peric 0x2 0x0>;
>@@ -468,8 +468,8 @@ pdma1: dma-controller@14290000 {
> reg = <0x0 0x14290000 0x0 0x1000>;
> interrupts = <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>;
> #dma-cells = <1>;
>- #dma-channels = <8>;
>- #dma-requests = <32>;
>+ dma-channels = <8>;
>+ dma-requests = <32>;
> clocks = <&clock_peric
>PERIC_DMA1_IPCLKPORT_ACLK>;
> clock-names = "apb_pclk";
> iommus = <&smmu_peric 0x1 0x0>;
>--
>2.32.0