Re: [PATCH v4 9/9] iio: accel: bma400: Add support for activity and inactivity events

From: Andy Shevchenko
Date: Wed Apr 27 2022 - 09:46:37 EST


On Wed, Apr 27, 2022 at 5:01 AM Jagath Jog J <jagathjog1996@xxxxxxxxx> wrote:
> On Sun, Apr 24, 2022 at 05:20:02PM +0100, Jonathan Cameron wrote:
> > On Thu, 21 Apr 2022 14:45:05 +0800
> > kernel test robot <lkp@xxxxxxxxx> wrote:
> > > Thank you for the patch! Perhaps something to improve:

...

> To avoid warning can I do like this
> field_value = FIELD_PREP(BMA400_INT_GEN1_MSK, state);


Can the same be used as below ?

> > > 1089 set_mask_bits(&data->generic_event_en, msk, field_value);

In other words, look for function macros in the bitfield.h.

--
With Best Regards,
Andy Shevchenko