Re: [PATCH v3 27/46] kmsan: instrumentation.h: add instrumentation_begin_with_regs()

From: Thomas Gleixner
Date: Wed Apr 27 2022 - 09:28:36 EST


On Tue, Apr 26 2022 at 18:42, Alexander Potapenko wrote:
> +void kmsan_instrumentation_begin(struct pt_regs *regs)
> +{
> + struct kmsan_context_state *state = &kmsan_get_context()->cstate;
> +
> + if (state)
> + __memset(state, 0, sizeof(struct kmsan_context_state));

sizeof(*state) please

> + if (!kmsan_enabled || !regs)
> + return;

Why has state to be cleared when kmsan is not enabled and how do you end up
with regs == NULL here?

Thanks,

tglx