On Tue, 26 Apr 2022 16:00:35 +0800
Li Huafei <lihuafei1@xxxxxxxxxx> wrote:
No, but if we are triggering these, then something really bad has happened,No need for all the 'goto reset_filter', if this function fails, then theThank you for the review. I see that we will disable function_graph tracer:
tracer is disabled, and there's no reason to clear the filter. In fact, it
/* Stop it if we failed */
if (ret)
ftrace_graph_stop();
But there is no function tracer disabled. Am I missing something that
would disable the function tracer?
and function tracer is possibly corrupted too, or should not be trusted.
No, but the system should be fixed. These should never trigger on any
may cause a crash (because something bad happened).Yes, so should we kill ftrace when the function_graph test fails?
production system, because it means something really bad is happening and
we do not know what.
Not resetting the filters may even be useful in debugging it. So that's
another reason to not do so.
-- Steve
.