Re: [PATCH] batman-adv: remove unnecessary type castings

[yuzhe]

I agree, this patch is better. And I have tested, no sparse warning anymore.

Thank your for your help.

      

在 2022/4/25 20:50, Sven Eckelmann 写道:

    

>        
> On Monday, 25 April 2022 13:36:35 CEST Yu Zhe wrote:
>        
> >          
> > remove unnecessary void* type castings.
> >
> > Signed-off-by: Yu Zhe<yuzhe@xxxxxxxxxxxx>
> > ---
> >   net/batman-adv/translation-table.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> >        
>        
> If you send a second version then please use `git format-patch -v2 ...` to
> format the patch. Now it looks in patchworks like you've resent the first
> version again. And please also add a little changelog after "---" which
> explains what you've changed. It is trivial in this little patch but still
> might be useful.
>
> Regarding the patch: Now you've removed bridge_loop_avoidance.c +
> batadv_choose_tt instead of fixing your patch. I would really prefer this
> patch version:
>
> https://git.open-mesh.org/linux-merge.git/commitdiff/8864d2fcf04385cabb8c8bb159f1f2ba5790cf71
>
> Kind regards,
> 	Sven
>