Re: [PATCH] x86/speculation: Add missing prototype for unpriv_ebpf_notify()

From: Borislav Petkov
Date: Tue Apr 26 2022 - 05:28:29 EST


+ bpf@xxxxxxxxxxxxxxx

Let's sync with bpf folks on who takes this. I could route it through tip ...

On Mon, Apr 25, 2022 at 04:40:02PM -0700, Josh Poimboeuf wrote:
> Fix the following warnings seen with "make W=1":
>
> kernel/sysctl.c:183:13: warning: no previous prototype for ‘unpriv_ebpf_notify’ [-Wmissing-prototypes]
> 183 | void __weak unpriv_ebpf_notify(int new_state)
> | ^~~~~~~~~~~~~~~~~~
>
> arch/x86/kernel/cpu/bugs.c:659:6: warning: no previous prototype for ‘unpriv_ebpf_notify’ [-Wmissing-prototypes]
> 659 | void unpriv_ebpf_notify(int new_state)
> | ^~~~~~~~~~~~~~~~~~
>
> Fixes: 44a3918c8245 ("x86/speculation: Include unprivileged eBPF status in Spectre v2 mitigation reporting")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> ---
> include/linux/bpf.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index bdb5298735ce..ecc3d3ec41cf 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -2085,6 +2085,8 @@ void bpf_offload_dev_netdev_unregister(struct bpf_offload_dev *offdev,
> struct net_device *netdev);
> bool bpf_offload_dev_match(struct bpf_prog *prog, struct net_device *netdev);
>
> +void unpriv_ebpf_notify(int new_state);
> +
> #if defined(CONFIG_NET) && defined(CONFIG_BPF_SYSCALL)
> int bpf_prog_offload_init(struct bpf_prog *prog, union bpf_attr *attr);
>
> --

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette