Re: [PATCH] drm/msm: change msm_sched_ops from global to static

[Dmitry Baryshkov]

On 21/04/2022 16:15, Tom Rix wrote:
> Smatch reports this issue
> msm_ringbuffer.c:43:36: warning: symbol 'msm_sched_ops' was not declared. Should it be static?
>
> msm_sched_ops is only used in msm_ringbuffer.c so change its
> storage-class specifier to static.
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

> ---
>   drivers/gpu/drm/msm/msm_ringbuffer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_ringbuffer.c b/drivers/gpu/drm/msm/msm_ringbuffer.c
> index 367a6aaa3a20..66f4ec09ef67 100644
> --- a/drivers/gpu/drm/msm/msm_ringbuffer.c
> +++ b/drivers/gpu/drm/msm/msm_ringbuffer.c
> @@ -40,7 +40,7 @@ static void msm_job_free(struct drm_sched_job *job)
>   	msm_gem_submit_put(submit);
>   }
>   
> -const struct drm_sched_backend_ops msm_sched_ops = {
> +static const struct drm_sched_backend_ops msm_sched_ops = {
>   	.run_job = msm_job_run,
>   	.free_job = msm_job_free
>   };


--
With best wishes
Dmitry