Re: [PATCH] drm/msm/hdmi: fix error check return value of irq_of_parse_and_map()

[Dmitry Baryshkov]

On 25/04/2022 23:11, Stephen Boyd wrote:
> Quoting cgel.zte@xxxxxxxxx (2022-04-25 02:18:31)
> > From: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
> >
> > The irq_of_parse_and_map() function returns 0 on failure, and does not
> > return a negative value anyhow, so never enter this conditional branch.
> >
> > Fixes: f6a8eaca0ea1 ("drm/msm/mdp5: use irqdomains")
> > Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> > Signed-off-by: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
> > ---
>
> This one fixes a commit that moved away from platform APIs!

The change was introduced in 2014 in the commit f6a8eaca0ea1 
("drm/msm/mdp5: use irqdomains"). I can suspect that at that time 
platform irq code wasn't fully compatible with IRQ domains.

> Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>


--
With best wishes
Dmitry