Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible string

From: Rob Herring
Date: Mon Apr 25 2022 - 16:26:53 EST


On Mon, Apr 25, 2022 at 12:32:51PM -0700, Stephen Boyd wrote:
> Quoting Rob Herring (2022-04-25 06:35:27)
> > The compatible string should be 'qcom,gcc-apq8064', not
> > 'qcom,gcc-apq8084'. Found by enabling undocumented compatible checks.
> >
> > Cc: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > index 97936411b6b4..9910a3e033bb 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
> > @@ -25,7 +25,7 @@ description: |
> >
> > properties:
> > compatible:
> > - const: qcom,gcc-apq8084
> > + const: qcom,gcc-apq8064
>
> This file has dt-bindings/clock/qcom,gcc-apq8084.h referenced. Should
> that be removed? It looks like commit a469bf89a009 ("dt-bindings: clock:
> simplify qcom,gcc-apq8064 Documentation") took the more than just the
> compatible for apq8084 from qcom,gcc-other.yaml and put it in here while
> removing gcc-apq8064. Probably the apq8084 part needs to be a copy of
> the apq8064 file with the single compatible changed.

IDK, can someone (Ansuel?) fix this properly?

Rob