Re: [PATCH] drm/msm/dpu: fix error check return value of irq_of_parse_and_map()

From: Stephen Boyd
Date: Mon Apr 25 2022 - 16:10:36 EST


Quoting cgel.zte@xxxxxxxxx (2022-04-25 02:09:47)
> From: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
>
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return a negative value anyhow, so never enter this conditional branch.
>
> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
> ---

Question still stands why we can't use platform device APIs.

Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>