Re: [PATCHv1 19/19] arm64: dts: rockchip: Add rk3588-evb1 board

[Rob Herring]

On Sat, Apr 23, 2022 at 12:09:21PM +0200, Krzysztof Kozlowski wrote:
> On 22/04/2022 19:09, Sebastian Reichel wrote:
> > From: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
> > 
> > Add board file for the RK3588 evaluation board. While the hardware
> > offers plenty of peripherals and connectivity this basic implementation
> > just handles things required to successfully boot Linux from eMMC
> > and connect via UART.
> > 
> > Signed-off-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
> > [rebase, update commit message, use EVB1 for SoC bringup]
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/arm/rockchip.yaml     |  5 +++
> >  arch/arm64/boot/dts/rockchip/Makefile         |  1 +
> >  .../boot/dts/rockchip/rk3588-evb1-v10.dts     | 34 +++++++++++++++++++
> >  3 files changed, 40 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > index eece92f83a2d..b14d0c84c69b 100644
> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > @@ -664,6 +664,11 @@ properties:
> >            - const: rockchip,rk3568-bpi-r2pro
> >            - const: rockchip,rk3568
> >  
> > +      - description: Rockchip RK3588 Evaluation board
> > +        items:
> > +          - const: rockchip,rk3588-evb1-v10
> > +          - const: rockchip,rk3588
> > +
> >  additionalProperties: true
> >  
> >  ...
> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> > index 4ae9f35434b8..8a53ab6d37a1 100644
> > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > @@ -61,3 +61,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.2.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
> >  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-evb1-v10.dtb
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > new file mode 100644
> > index 000000000000..68b19acb1550
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts
> > @@ -0,0 +1,34 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > + * Copyright (c) 2021 Rockchip Electronics Co., Ltd.
> > + *
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "rk3588.dtsi"
> > +
> > +/ {
> > +	model = "Rockchip RK3588 EVB1 V10 Board";
> > +	compatible = "rockchip,rk3588-evb1-v10", "rockchip,rk3588";
> > +
> > +	chosen {
> > +		stdout-path = "serial2:1500000n8";
> > +	};
> > +};
> > +
> > +&sdhci {
> > +	bus-width = <8>;
> > +	no-sdio;
> > +	no-sd;
> > +	non-removable;
> > +	max-frequency = <200000000>;
> > +	mmc-hs400-1_8v;
> > +	mmc-hs400-enhanced-strobe;
> > +	status = "ok";
> > +};
> > +
> > +&uart2 {
> > +	status = "ok";
> 
> Usually status goes at the end of properties and rockchip sources use
> "okay" instead of "ok".

"okay" is what's documented in the spec and in the schemas, so please 
fix. 

No need for reviewers to tell you this though, please run 'make 
dtbs_checks' on the dts file and don't add new warnings.

Rob