Re: [PATCH v3] dt-bindings: gnss: Rewrite Mediatek bindings in YAML

From: Krzysztof Kozlowski
Date: Mon Apr 25 2022 - 13:49:25 EST


On 25/04/2022 15:29, Linus Walleij wrote:
> This rewrites the Mediatek GNSS bindings in YAML.
>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> ChangeLog v2->v3:
> - Add the missed gnss-fix-gpios.
> - Move allOf to right before the properties.
> - Keep the description on timepulse-gpios because it documents
> which pins are used on this chip.
> ChangeLog v1->v2:
> - New patch since Krzysztof pointed out there is really just
> one more binding to convert, so why not.
> ---
> .../devicetree/bindings/gnss/mediatek.txt | 35 -----------
> .../devicetree/bindings/gnss/mediatek.yaml | 59 +++++++++++++++++++

Bindings look good, just the filename should be probably more specific,
to match the model... but then who is the vendor? mediatek,pa6h.yaml or
mediatek,globaltop-pa6h.yaml? I sincerely do not know, so:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>


Best regards,
Krzysztof