Re: [PATCH v2 1/6] dt-bindings: hwmon: Add nuvoton,nct6775

From: Guenter Roeck
Date: Mon Apr 25 2022 - 11:08:10 EST


On Tue, Mar 08, 2022 at 04:50:42PM -0800, Zev Weiss wrote:
> These Super I/O chips have an i2c interface that some systems expose
> to a BMC; the BMC's device tree can now describe that via this
> binding.
>
> Signed-off-by: Zev Weiss <zev@xxxxxxxxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>

This is still waiting for DT maintainer approval.

Do you expect to add further properties along the line ?
If not, you might consider adding the chips to trivial devices instead.

Guenter

> ---
> .../bindings/hwmon/nuvoton,nct6775.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml b/Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml
> new file mode 100644
> index 000000000000..7b1054db46b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/nuvoton,nct6775.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NCT6775 and compatible Super I/O chips
> +
> +maintainers:
> + - Zev Weiss <zev@xxxxxxxxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - nuvoton,nct6106
> + - nuvoton,nct6116
> + - nuvoton,nct6775
> + - nuvoton,nct6776
> + - nuvoton,nct6779
> + - nuvoton,nct6791
> + - nuvoton,nct6792
> + - nuvoton,nct6793
> + - nuvoton,nct6795
> + - nuvoton,nct6796
> + - nuvoton,nct6797
> + - nuvoton,nct6798
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + superio@4d {
> + compatible = "nuvoton,nct6779";
> + reg = <0x4d>;
> + };
> + };