Re: [PATCH 1/4] scsi: core: constify pointer to scsi_host_template

From: John Garry
Date: Mon Apr 25 2022 - 04:59:09 EST


On 20/04/2022 08:03, Christoph Hellwig wrote:
The standard flow is:

shost = scsi_host_alloc(sht, )

// modify shost, like
shost->cmd_per_lun = 5;

scsi_add_host(shost)

Is there some reason for which those two drivers can't follow that?
I think they should. Method tables should not be mutable data.
.

Hi Krzysztof,

Do you have any interest in going further with your work and trying to change all SCSI driver instances of scsi_host_template to be const? I am not sure if it has been attempted before...

Thanks,
John