Re: [PATCH] mm/memcg: minor cleanup in non-memcg_kmem version of mem_cgroup_from_obj()

From: Michal Hocko
Date: Mon Apr 25 2022 - 03:37:24 EST


On Sat 23-04-22 05:23:03, Vasily Averin wrote:
> Replace leading spaces by tab:
> WARNING: please, no spaces at the start of a line
> #X: FILE: include/linux/memcontrol.h:1480:
> + return NULL;$
>
> Fixes: commit 8380ce479010 ("mm: fork: fix kernel_stack memcg stats for various stack implementations")

Please drop the Fixes tag. The tag is supposed to point to a functional
breakage and this is purely a style fix.

> Signed-off-by: Vasily Averin <vvs@xxxxxxxxxx>

Acked-by: Michal Hocko <mhocko@xxxxxxxx>

> ---
> include/linux/memcontrol.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index a68dce3873fc..294515d06dbe 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1753,7 +1753,7 @@ static inline int memcg_kmem_id(struct mem_cgroup *memcg)
>
> static inline struct mem_cgroup *mem_cgroup_from_obj(void *p)
> {
> - return NULL;
> + return NULL;
> }
>
> #endif /* CONFIG_MEMCG_KMEM */
> --
> 2.25.1

--
Michal Hocko
SUSE Labs