Re: [PATCH] ALSA: pcm: Check for null pointer of pointer substream before dereferencing it

From: Takashi Iwai
Date: Mon Apr 25 2022 - 01:53:42 EST


On Sun, 24 Apr 2022 22:59:45 +0200,
Colin Ian King wrote:
>
> Pointer substream is being dereferenced on the assignment of pointer card
> before substream is being null checked with the macro PCM_RUNTIME_CHECK.
> Although PCM_RUNTIME_CHECK calls BUG_ON, it still is useful to perform the
> the pointer check before card is assigned.
>
> Fixes: commit d4cfb30fce03 ("ALSA: pcm: Set per-card upper limit of PCM buffer allocations")
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Thanks, applied with the correction of Fixes tag.


Takashi