RE: [PATCH] drm/amd/display: fix if == else warning

[Liu, Zhan]

[AMD Official Use Only - General]

> -----Original Message-----
> From: Guo Zhengkui <guozhengkui@xxxxxxxx>
> Sent: 2022/April/24, Sunday 5:06 AM
> To: Wentland, Harry <Harry.Wentland@xxxxxxx>; Li, Sun peng (Leo)
> <Sunpeng.Li@xxxxxxx>; Siqueira, Rodrigo <Rodrigo.Siqueira@xxxxxxx>;
> Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian
> <Christian.Koenig@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; David Airlie
> <airlied@xxxxxxxx>; Daniel Vetter <daniel@xxxxxxxx>; Liu, Charlene
> <Charlene.Liu@xxxxxxx>; Lei, Jun <Jun.Lei@xxxxxxx>; Guo Zhengkui
> <guozhengkui@xxxxxxxx>; Liu, Zhan <Zhan.Liu@xxxxxxx>; José Expósito
> <jose.exposito89@xxxxxxxxx>; open list:AMD DISPLAY CORE <amd-
> gfx@xxxxxxxxxxxxxxxxxxxxx>; open list:DRM DRIVERS <dri-
> devel@xxxxxxxxxxxxxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx>
> Cc: zhengkui_guo@xxxxxxxxxxx
> Subject: [PATCH] drm/amd/display: fix if == else warning
>
> Fix the following coccicheck warning:
>
> drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c:98:8-10:
> WARNING: possible condition with no effect (if == else)
>
> Signed-off-by: Guo Zhengkui <guozhengkui@xxxxxxxx>

Thanks a lot for fixing this warning.

Reviewed-by: Zhan Liu <zhan.liu@xxxxxxx>

> ---
>  drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> index fe22530242d2..05b3fba9ccce 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_hwseq.c
> @@ -95,8 +95,6 @@ static void gpu_addr_to_uma(struct dce_hwseq *hwseq,
>       } else if (hwseq->fb_offset.quad_part <= addr->quad_part &&
>                       addr->quad_part <= hwseq->uma_top.quad_part) {
>               is_in_uma = true;
> -     } else if (addr->quad_part == 0) {
> -             is_in_uma = false;
>       } else {
>               is_in_uma = false;
>       }
> --
> 2.20.1