Re: [PATCH v2] pinctrl: fix error check return value of irq_of_parse_and_map()

From: Linus Walleij
Date: Sun Apr 24 2022 - 10:25:26 EST


On Sun, Apr 24, 2022 at 5:14 AM <cgel.zte@xxxxxxxxx> wrote:

> From: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
>
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return an negative value.
>
> Fixes: cefc03e5995e ("pinctrl: Add Pistachio SoC pin control driver")
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Lv Ruyi <lv.ruyi@xxxxxxxxxx>
> ---
> v2: don't print irq, and return -EINVAL rather than 0

Patch applied for fixes (changed the subject a bit).

Thanks!
Linus Walleij