Re: [PATCH v4] watchdog: imx2_wdg: Allow ping on suspend

From: Alistair
Date: Wed Mar 23 2022 - 17:09:23 EST


On Wed, 23 Mar 2022, at 11:07 PM, Guenter Roeck wrote:
> On 3/23/22 04:57, Alistair Francis wrote:
> > The i.MX watchdog cannot be disabled by software once it has been
> > enabled. This means that it can't be stopped before suspend.
> >
> > For systems that enter low power mode this is fine, as the watchdog will
> > be automatically stopped by hardware in low power mode. Not all i.MX
> > platforms support low power mode in the mainline kernel. For example the
> > i.MX7D does not enter low power mode and so will be rebooted 2 minutes
> > after entering sleep states.
> >
> > This patch introduces a device tree property "fsl,ping-during-suspend"
> > that can be used to enable ping on suspend support for these systems.
> >
> > Signed-off-by: Alistair Francis <alistair@xxxxxxxxxxxxx>
> > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>
> What is the difference to earlier versions ?

Sorry, I should have included a changelog.

I just fixed the spelling of alow/allow in the title

Alistair

>
> Guenter
>