Re: [PATCH -next] ASoC: tlv320adc3xxx: Fix build error when GPIOLIB is not set

[Mark Brown]

On Wed, Mar 23, 2022 at 10:17:36PM +0800, Baisong Zhong wrote:

>  config SND_SOC_TLV320ADC3XXX
>  	tristate "Texas Instruments TLV320ADC3001/3101 audio ADC"
> -	depends on I2C
> +	depends on I2C && GPIOLIB

This is bogus, the device clearly doesn't require GPIOs to be useful and
so there shouldn't be a dependency on gpiolib which normally stubs out.
In general for APIs with stubs adding a config dependency is not the right
thing to do.

I suspect it's just a missing header.

Attachment: signature.asc
Description: PGP signature