Re: [PATCH V2] android: binder: Fix duplicate included binder_trace.h

From: Todd Kjos
Date: Wed Mar 23 2022 - 11:21:30 EST


On Tue, Mar 22, 2022 at 8:12 PM Haowen Bai <baihaowen@xxxxxxxxx> wrote:
>
> Clean up the following includecheck warning:
>
> drivers/android/binder.c: binder_trace.h is included more than once.
>
> No functional change.
>
> Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>
> ---
> V1 -> V2: modify title asm/pgtable.h -> binder_trace.h
>
> drivers/android/binder.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 8351c56..a12aa3c 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -72,7 +72,6 @@
> #include <linux/cacheflush.h>
>
> #include "binder_internal.h"
> -#include "binder_trace.h"

This breaks the build. Please test your changes before submitting.

>
> static HLIST_HEAD(binder_deferred_list);
> static DEFINE_MUTEX(binder_deferred_lock);
> --
> 2.7.4
>