Re: [PATCH net-next] tcp: make tcp_rcv_state_process() drop monitor friendly

[Eric Dumazet]

On Wed, Mar 23, 2022 at 6:05 AM Jianguo Wu <wujianguo106@xxxxxxx> wrote:
>
> From: Jianguo Wu <wujianguo@xxxxxxxxxxxxxxx>
>
> In tcp_rcv_state_process(), should not call tcp_drop() for same case,
> like after process ACK packet in TCP_LAST_ACK state, it should call
> consume_skb() instead of tcp_drop() to be drop monitor friendly,
> otherwise every last ack will be report as dropped packet by drop monitor.
>
> Signed-off-by: Jianguo Wu <wujianguo@xxxxxxxxxxxxxxx>
> ---

1) net-next is closed

2) Same remarks as for the other patch.
   You mark the packet as consumed, while maybe we had to throw away
some payload from it ?

You will have to wait for net-next being open,
then send patches with one change at a time, with clear explanations
and possibly packetdrill tests.

I am concerned about all these patches making future backports
difficult because of merge conflicts.