Re: [PATCH v2] ufs: qcom: drop custom Android boot parameters

From: 'Krzysztof Kozlowski'
Date: Tue Mar 22 2022 - 14:14:56 EST


On 21/03/2022 16:40, Alim Akhtar wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzk@xxxxxxxxxx]
>> Sent: Monday, March 21, 2022 8:49 PM
>> To: Andy Gross <agross@xxxxxxxxxx>; Bjorn Andersson
>> <bjorn.andersson@xxxxxxxxxx>; Alim Akhtar <alim.akhtar@xxxxxxxxxxx>;
>> Avri Altman <avri.altman@xxxxxxx>; James E.J. Bottomley
>> <jejb@xxxxxxxxxxxxx>; Martin K. Petersen <martin.petersen@xxxxxxxxxx>;
>> linux-arm-msm@xxxxxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; linux-
>> kernel@xxxxxxxxxxxxxxx
>> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>; Amit Pundir
>> <amit.pundir@xxxxxxxxxx>; Luca Weiss <luca.weiss@xxxxxxxxxxxxx>; Brian
>> Masney <bmasney@xxxxxxxxxx>
>> Subject: [PATCH v2] ufs: qcom: drop custom Android boot parameters
>>
>> The QCOM UFS driver requires an androidboot.bootdevice command line
>> argument matching the UFS device name. If the name is different, it
> refuses
>> to probe. This androidboot.bootdevice is provided by stock/vendor (from an
>> Android-based device) bootloader.
>>
>> This does not make sense from Linux point of view. Driver should be able
> to
>> boot regardless of bootloader. Driver should not depend on some Android
>> custom environment data.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>> Tested-by: Amit Pundir <amit.pundir@xxxxxxxxxx>
>> Tested-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
>> Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>>
>
> Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

Ah, sorry, I think I missed your Rb from v1.


Best regards,
Krzysztof