Re: [PATCH v2] staging: rtl8712: Fix CamelCase warnings

[Sathish Kumar]

On 18/03/22 4:58 pm, Greg KH wrote:
> On Fri, Mar 18, 2022 at 03:44:40PM +0530, Sathish Kumar wrote:
> > This patch fixes the checkpatch.pl warnings like:
> > CHECK: Avoid CamelCase: <blnEnableRxFF0Filter>
> > +   u8 blnEnableRxFF0Filter;
> >
> > Signed-off-by: Sathish Kumar <skumark1902@xxxxxxxxx>
> > ---
> > Changes in v2:
> >      - Remove the "bln" prefix
> > ---
> >   drivers/staging/rtl8712/drv_types.h   | 2 +-
> >   drivers/staging/rtl8712/rtl871x_cmd.c | 2 +-
> >   drivers/staging/rtl8712/xmit_linux.c  | 4 ++--
> >   3 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> > index a44d04effc8b..4de3aad08242 100644
> > --- a/drivers/staging/rtl8712/drv_types.h
> > +++ b/drivers/staging/rtl8712/drv_types.h
> > @@ -157,7 +157,7 @@ struct _adapter {
> >   	struct iw_statistics iwstats;
> >   	int pid; /*process id from UI*/
> >   	struct work_struct wk_filter_rx_ff0;
> > -	u8 blnEnableRxFF0Filter;
> > +	u8 enable_rx_ff0_filter;
> Shouldn't this be a boolean?
>
> >   	spinlock_t lock_rx_ff0_filter;
> >   	const struct firmware *fw;
> >   	struct usb_interface *pusb_intf;
> > diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c b/drivers/staging/rtl8712/rtl871x_cmd.c
> > index acda930722b2..69d3c55ee9e5 100644
> > --- a/drivers/staging/rtl8712/rtl871x_cmd.c
> > +++ b/drivers/staging/rtl8712/rtl871x_cmd.c
> > @@ -202,7 +202,7 @@ u8 r8712_sitesurvey_cmd(struct _adapter *padapter,
> >   	mod_timer(&pmlmepriv->scan_to_timer,
> >   		  jiffies + msecs_to_jiffies(SCANNING_TIMEOUT));
> >   	padapter->ledpriv.LedControlHandler(padapter, LED_CTL_SITE_SURVEY);
> > -	padapter->blnEnableRxFF0Filter = 0;
> > +	padapter->enable_rx_ff0_filter = 0;
> >   	return _SUCCESS;
> >   }
> >   
> > diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c
> > index 90d34cf9d2ff..d58ae5b387d4 100644
> > --- a/drivers/staging/rtl8712/xmit_linux.c
> > +++ b/drivers/staging/rtl8712/xmit_linux.c
> > @@ -102,11 +102,11 @@ void r8712_SetFilter(struct work_struct *work)
> >   	r8712_write8(adapter, 0x117, newvalue);
> >   
> >   	spin_lock_irqsave(&adapter->lock_rx_ff0_filter, irqL);
> > -	adapter->blnEnableRxFF0Filter = 1;
> > +	adapter->enable_rx_ff0_filter = 1;
> >   	spin_unlock_irqrestore(&adapter->lock_rx_ff0_filter, irqL);
> >   	do {
> >   		msleep(100);
> > -	} while (adapter->blnEnableRxFF0Filter == 1);
> > +	} while (adapter->enable_rx_ff0_filter == 1);
> Ah, that's funny.  It's amazing it works at all and that the compiler
> doesn't optimize this away.  This isn't a good pattern to use in kernel
Do you mean the following code is not a good pattern in kernel?
do {
msleep();
} while(condition);
> code.  I know it's not caused by your change here, but perhaps you might
> want to fix this up to work properly?
>
> thanks,
>
> greg k-h

Do i need to replace the above code with some other mechanism?

If yes, please let me know which mechanism i should use? Or what should 
I do here?

Note : I am new to Linux kernel development and looking forward to learn 
and contribute.

Thanks,
Sathish