Re: [PATCH] MAINTAINERS: sifive: drop Yash Shah

[Palmer Dabbelt]

On Thu, 10 Mar 2022 23:33:54 PST (-0800), krzysztof.kozlowski@xxxxxxxxxxxxx wrote:
> On 11/03/2022 04:14, Palmer Dabbelt wrote:
> > On Mon, 14 Feb 2022 00:23:49 PST (-0800), krzysztof.kozlowski@xxxxxxxxxxxxx wrote:
> > > Emails to Yash Shah bounce with "The email account that you tried to
> > > reach does not exist.", so drop him from all maintainer entries.
> > >
> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> > > ---
> > >  Documentation/devicetree/bindings/gpio/sifive,gpio.yaml     | 1 -
> > >  Documentation/devicetree/bindings/pwm/pwm-sifive.yaml       | 1 -
> > >  .../devicetree/bindings/riscv/sifive-l2-cache.yaml          | 1 -
> > >  MAINTAINERS                                                 | 6 ------
> > >  4 files changed, 9 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
> > > index e04349567eeb..427c5873f96a 100644
> > > --- a/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
> > > +++ b/Documentation/devicetree/bindings/gpio/sifive,gpio.yaml
> > > @@ -7,7 +7,6 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> > >  title: SiFive GPIO controller
> > >
> > >  maintainers:
> > > -  - Yash Shah <yash.shah@xxxxxxxxxx>
> > >    - Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> > >
> > >  properties:
> > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
> > > index 676b2160bada..605c1766dba8 100644
> > > --- a/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
> > > +++ b/Documentation/devicetree/bindings/pwm/pwm-sifive.yaml
> > > @@ -8,7 +8,6 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> > >  title: SiFive PWM controller
> > >
> > >  maintainers:
> > > -  - Yash Shah <yash.shah@xxxxxxxxxx>
> > >    - Sagar Kadam <sagar.kadam@xxxxxxxxxx>
> > >    - Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> > >
> > > diff --git a/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml b/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml
> > > index 2b1f91603897..e2d330bd4608 100644
> > > --- a/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml
> > > +++ b/Documentation/devicetree/bindings/riscv/sifive-l2-cache.yaml
> > > @@ -9,7 +9,6 @@ title: SiFive L2 Cache Controller
> > >
> > >  maintainers:
> > >    - Sagar Kadam <sagar.kadam@xxxxxxxxxx>
> > > -  - Yash Shah <yash.shah@xxxxxxxxxx>
> > >    - Paul Walmsley  <paul.walmsley@xxxxxxxxxx>
> > >
> > >  description:
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index ebf7a75a6bec..87eeac970ca2 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -7090,12 +7090,6 @@ L:	linux-edac@xxxxxxxxxxxxxxx
> > >  S:	Maintained
> > >  F:	drivers/edac/sb_edac.c
> > >
> > > -EDAC-SIFIVE
> > > -M:	Yash Shah <yash.shah@xxxxxxxxxx>
> > > -L:	linux-edac@xxxxxxxxxxxxxxx
> > > -S:	Supported
> > > -F:	drivers/edac/sifive_edac.c
> >
> > Looks like that leaves this unmaintained?  I'm happy to volunteer, I've
> > got the boards lying around somewhere and sort of feel on the hook to
> > keep this stuff alive given that whatever's in there is partially my
> > fault.  That said, I'm happy to stay out of it so if it's OK to have
> > otherwise unmaintained EDAC drivers that works for me so
> >
> > Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
>
> The patch was already merged. EDAC SiFive is now covered by generic EDAC
> and SIFIVE entries. Feel free to restore the entry with yourself.

Sorry for being vague there, I'd seen it get merged.

If having it covered via some generic MAINTAINERS entries is OK for the 
EDAC folks then that's fine with me, I just don't want to get into a 
spot where this driver is going to get removed because nobody's more 
explicitly maintaining it.  These SiFive boards are still the only ones 
that run a normal-smelling upstream Linux (at least until we can get the 
D1 issues sorted out, which is hopefully soon) and I'd hate to start 
dropping stuff if we don't need to.

So if it's fine for the EDAC forks to have things in the state the are 
after this patch was merged, that's great for me.

> Best regards,
> Krzysztof