Re: [net-next PATCH v4 1/7] octeon_ep: Add driver framework and device initialization

[Jakub Kicinski]

On Sun, 20 Mar 2022 22:53:31 -0700 Veerasenareddy Burru wrote:
> Add driver framework and device setup and initialization for Octeon
> PCI Endpoint NIC.
> 
> Add implementation to load module, initilaize, register network device,
> cleanup and unload module.
> 
> Signed-off-by: Veerasenareddy Burru <vburru@xxxxxxxxxxx>
> Signed-off-by: Abhijit Ayarekar <aayarekar@xxxxxxxxxxx>
> Signed-off-by: Satananda Burla <sburla@xxxxxxxxxxx>

Clang says:

drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c:51:19: warning: unused function 'octep_ctrl_mbox_circq_inc' [-Wunused-function]
static inline u32 octep_ctrl_mbox_circq_inc(u32 index, u32 mask)
                  ^
drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c:56:19: warning: unused function 'octep_ctrl_mbox_circq_space' [-Wunused-function]
static inline u32 octep_ctrl_mbox_circq_space(u32 pi, u32 ci, u32 mask)
                  ^
drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c:61:19: warning: unused function 'octep_ctrl_mbox_circq_depth' [-Wunused-function]
static inline u32 octep_ctrl_mbox_circq_depth(u32 pi, u32 ci, u32 mask)
                  ^

Please don't use static inlines in C files, static is enough for 
the compiler to do a reasonable job.

Please fix and repost in 2 weeks we're currently in the merge window
so networking trees are not accepting new drivers.

Thanks.