Re: [PATCH v5 03/22] cachefiles: introduce on-demand read mode

From: David Howells
Date: Mon Mar 21 2022 - 10:23:57 EST


Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:

> Why do you have a separate rwlock when the xarray already has its own
> spinlock? This is usually a really bad idea.

Jeffle wants to hold a lock across the CACHEFILES_DEAD check and the xarray
access.

However, he tells xarray to do a GFP_KERNEL alloc whilst holding the rwlock:-/

David