RE: [PATCH v2] iio:filter:admv8818: select REGMAP_SPI for ADMV8818

[Sa, Nuno]

> -----Original Message-----
> From: Wang ShaoBo <bobo.shaobowang@xxxxxxxxxx>
> Sent: Sunday, March 20, 2022 6:55 AM
> Cc: cj.chengjian@xxxxxxxxxx; liwei391@xxxxxxxxxx;
> bobo.shaobowang@xxxxxxxxxx; Miclaus, Antoniu
> <Antoniu.Miclaus@xxxxxxxxxx>; Sa, Nuno <Nuno.Sa@xxxxxxxxxx>;
> linux-iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> jic23@xxxxxxxxxx; Jonathan.Cameron@xxxxxxxxxx
> Subject: [PATCH v2] iio:filter:admv8818: select REGMAP_SPI for
> ADMV8818
> 
> [External]
> 
> admv8818 driver needs __devm_regmap_init_spi() which is defined
> when CONFIG_REGMAP_SPI is set and struct regmap_config when
> CONFIG_REGMAP is set, so automatically select CONFIG_REGMAP_SPI
> which also sets CONFIG_REGMAP.
> 
> Fixes: f34fe888ad05 ("iio:filter:admv8818: add support for ADMV8818")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@xxxxxxxxxx>
> ---

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>

>  drivers/iio/filter/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/filter/Kconfig b/drivers/iio/filter/Kconfig
> index 3ae35817ad82..a85b345ea14e 100644
> --- a/drivers/iio/filter/Kconfig
> +++ b/drivers/iio/filter/Kconfig
> @@ -8,6 +8,7 @@ menu "Filters"
>  config ADMV8818
>  	tristate "Analog Devices ADMV8818 High-Pass and Low-Pass
> Filter"
>  	depends on SPI && COMMON_CLK && 64BIT
> +	select REGMAP_SPI
>  	help
>  	  Say yes here to build support for Analog Devices ADMV8818
>  	  2 GHz to 18 GHz, Digitally Tunable, High-Pass and Low-Pass
> Filter.
> --
> 2.25.1