答复: [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags

[白浩文]

Hi, sir

Ok, thank you for your reminder.
________________________________________
发件人: Jiri Slaby <jirislaby@xxxxxxxxxx>
发送时间: 2022年3月21日 14:03:09
收件人: 白浩文; arnd@xxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; dsterba@xxxxxxxx; elder@xxxxxxxxxx; jcmvbkbc@xxxxxxxxx
抄送: johan@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
主题: Re: [PATCH] try: synclink_cs: Use bitwise instead of arithmetic operator for flags

Hi,

the $SUBJ says:

"try: synclink_cs: ..."

but you actually meant "tty:".

On 21. 03. 22, 4:04, Haowen Bai wrote:
> This silences the following coccinelle warning:
> drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |
>
> we will try to make code cleaner
>
> Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>
> ---
>   drivers/char/pcmcia/synclink_cs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
> index 78baba5..e6f2186 100644
> --- a/drivers/char/pcmcia/synclink_cs.c
> +++ b/drivers/char/pcmcia/synclink_cs.c
> @@ -922,7 +922,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int tcd)
>               // BIT7:parity error
>               // BIT6:framing error
>
> -             if (status & (BIT7 + BIT6)) {
> +             if (status & (BIT7 | BIT6)) {
>                       if (status & BIT7)
>                               icount->parity++;
>                       else


--
js
suse labs