Re: [PATCH] tpm/tpm_ftpm_tee: Return true/false (not 1/0) from bool functions

From: Jarkko Sakkinen
Date: Sun Mar 20 2022 - 17:14:29 EST


On Fri, Mar 18, 2022 at 11:35:25AM +0800, Haowen Bai wrote:
> Return boolean values ("true" or "false") instead of 1 or 0 from bool
> functions.
>
> Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>
> ---
> drivers/char/tpm/tpm_ftpm_tee.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.c b/drivers/char/tpm/tpm_ftpm_tee.c
> index 6e32355..5c23342 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.c
> +++ b/drivers/char/tpm/tpm_ftpm_tee.c
> @@ -177,7 +177,7 @@ static u8 ftpm_tee_tpm_op_status(struct tpm_chip *chip)
>
> static bool ftpm_tee_tpm_req_canceled(struct tpm_chip *chip, u8 status)
> {
> - return 0;
> + return false;
> }
>
> static const struct tpm_class_ops ftpm_tee_tpm_ops = {
> --
> 2.7.4
>

Reviewed-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>

BR, Jarkko