Re: [PATCH v4 13/20] netfs: Add a netfs inode context

[David Howells]

Jeff Layton <jlayton@xxxxxxxxxx> wrote:

> > +static inline bool netfs_is_cache_enabled(struct netfs_i_context *ctx)
> > +{
> > +#if IS_ENABLED(CONFIG_FSCACHE)
> > +	struct fscache_cookie *cookie = ctx->cache;
> > +
> > +	return fscache_cookie_valid(cookie) && cookie->cache_priv &&
> > +		fscache_cookie_enabled(cookie);
> 
> 
> As you mentioned in the other thread, it may be cleaner to move the
> cookie->cache_priv check into fscache_cookie_enabled. Is there ever a
> case where you'd need to separate the two checks?

I'm not sure, but I'd prefer not to do it in this series as it would affect
NFS plus some other operations, so will need retesting thoroughly.  I'd prefer
to defer it.

David