On Thu, Mar 17, 2022 at 9:04 AM Christian König
<christian.koenig@xxxxxxx> wrote:
Am 17.03.22 um 16:10 schrieb Rob Clark:Hmm, perhaps that is true if you need to migrate things out of vram?
[SNIP]Well exactly that's the problem. The scheduler is supposed to shoveling
userspace frozen != kthread frozen .. that is what this patch is
trying to address, so we aren't racing between shutting down the hw
and the scheduler shoveling more jobs at us.
more jobs at us until it is empty.
Thinking more about it we will then keep some dma_fence instance
unsignaled and that is and extremely bad idea since it can lead to
deadlocks during suspend.
It is at least not a problem when vram is not involved.
So this patch here is an absolute clear NAK from my side. If amdgpu isI think amdgpu's use of kthread_park is not related to suspend, but
doing something similar that is a severe bug and needs to be addressed
somehow.
didn't look too closely.
And perhaps the solution for this problem is more complex in the case
of amdgpu, I'm not super familiar with the constraints there. But I
think it is a fine solution for integrated GPUs.
BR,
-R
Regards,
Christian.
BR,
-R