Re: [PATCH 2/3] drm/msm/gpu: Park scheduler threads for system suspend

From: Christian König
Date: Thu Mar 17 2022 - 12:05:07 EST


Am 17.03.22 um 16:10 schrieb Rob Clark:
[SNIP]
userspace frozen != kthread frozen .. that is what this patch is
trying to address, so we aren't racing between shutting down the hw
and the scheduler shoveling more jobs at us.

Well exactly that's the problem. The scheduler is supposed to shoveling more jobs at us until it is empty.

Thinking more about it we will then keep some dma_fence instance unsignaled and that is and extremely bad idea since it can lead to deadlocks during suspend.

So this patch here is an absolute clear NAK from my side. If amdgpu is doing something similar that is a severe bug and needs to be addressed somehow.

Regards,
Christian.


BR,
-R