RE: [PATCH 3/3] spi: dt-bindings: Add wait state polling flag

From: Krishna Yarlagadda
Date: Thu Mar 17 2022 - 05:03:21 EST


> -----Original Message-----
> From: Mikko Perttunen <cyndis@xxxxxxxx>
> Sent: 17 March 2022 14:13
> To: Krishna Yarlagadda <kyarlagadda@xxxxxxxxxx>; broonie@xxxxxxxxxx; thierry.reding@xxxxxxxxx; Jonathan Hunter
> <jonathanh@xxxxxxxxxx>; linux-spi@xxxxxxxxxxxxxxx; linux-tegra@xxxxxxxxxxxxxxx; Ashish Singhal <ashishsingha@xxxxxxxxxx>
> Cc: Sowjanya Komatineni <skomatineni@xxxxxxxxxx>; Laxman Dewangan <ldewangan@xxxxxxxxxx>; robh+dt@xxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 3/3] spi: dt-bindings: Add wait state polling flag
>
> External email: Use caution opening links or attachments
>
>
> On 3/17/22 03:20, Krishna Yarlagadda wrote:
> > Add flag to enable tpm wait state polling and Tegra Grace binding.
> >
> > Signed-off-by: Krishna Yarlagadda <kyarlagadda@xxxxxxxxxx>
> > ---
> > .../devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> > index 0296edd1de22..88b00fcad210 100644
> > --- a/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> > +++ b/Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml
> > @@ -20,6 +20,7 @@ properties:
> > - nvidia,tegra186-qspi
> > - nvidia,tegra194-qspi
> > - nvidia,tegra234-qspi
> > + - nvidia,tegra-grace-qspi
>
> nvidia,tegra241-qspi. Similarly in other places that refer to the chip name.
Agree. Will change it to be consistent with rest of the chip patches.
>
> Mikko
>
> >
> > reg:
> > maxItems: 1
> > @@ -57,6 +58,11 @@ patternProperties:
> > spi-tx-bus-width:
> > enum: [1, 2, 4]
> >
> > + nvidia,wait-polling:
> > + description:
> > + Enable TPM wait state polling on supported chips.
> > + type: boolean
> > +
> > nvidia,tx-clk-tap-delay:
> > description:
> > Delays the clock going out to device with this tap value.