Re: [PATCH v3] livepatch: Don't block removal of patches that are safe to unload

From: Miroslav Benes
Date: Wed Mar 16 2022 - 11:04:06 EST


> > > + /*
> > > + * Only need to set forced flag for the transition patch
> > > + * when force transition to KLP_UNPATCHED state, but
> > > + * have to set forced flag for all replaced patches
> > > + * when force atomic replace transition.
> > > + */
> >
> > How about something like
> >
> > /*
> > * Set forced flag for patches being removed, which is the transition
> > * patch in KLP_UNPATCHED state or all replaced patches when forcing
> > * the atomic replace transition.
> > */
>
> Or just the first sentence:
>
> /* Set forced flag for patches being removed */
>
> The rest is visible from the code.

True. This would work for me as well.

Miroslav