Re: [PATCH] fs/exec.c: Avoid a race in formats

From: Yun Levi
Date: Wed Feb 23 2022 - 21:28:40 EST


On Thu, Feb 24, 2022 at 11:25 AM Eric W. Biederman
<ebiederm@xxxxxxxxxxxx> wrote:
> I took a quick look and unregistering in the module exit routine looks
> safe, as set_binfmt takes a module reference, and so prevents the module
> from being unloaded.
>
> If you can find a bug with existing in-kernel code that would be
> interesting. Otherwise you are making up assumptions that don't current
> match the code and saying the code is bugging with respect to
> assumptions that do not hold.
>
> The code in the kernel is practical not an implementation of some
> abstract that is robust for every possible use case.
>
> Eric

Thanks and sorry for making a noise.