Re: [RFC V4 1/6] blk: prepare to make blk-rq-qos pluggable and modular

From: Tejun Heo
Date: Wed Feb 23 2022 - 16:37:27 EST


Hello,

> > We just want to provide the flexibility for the user to open/close a policy
> > per device. If we need to the policy on a device, we needn't to waste cpu
> sorry, it should be "If we don't need the policy on a device" ;)

Yeah, that's what modularization does but why does it need a separate user
interface for loading? Everything else inits on insmod and exits on rmmod
and autoloading has been delegated to udev a very long time ago. The
interface you added for loading module doesn't make sense to me.

Thanks.

--
tejun