Re: [PATCH v7 03/11] dt-bindings: rtc: add bindings for microchip mpfs rtc

[Conor Dooley]

On 23/02/2022 20:20, Alexandre Belloni wrote:
> On 23/02/2022 15:25:00+0000, Conor.Dooley@xxxxxxxxxxxxx wrote:
> > On 23/02/2022 15:18, Alexandre Belloni wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > >
> > > On 23/02/2022 07:41:27+0000, Conor.Dooley@xxxxxxxxxxxxx wrote:
> > > > Hi Alessandro, Alexandre,
> > > > If one of you could take a look at this, that'd be great.
> > >
> > > I actually expected someone else to apply this, what is your plan?
> >
> > I was going to ask Palmer to take the series via riscv. Since I have
> > Rob's R-b, I was just looking for a subsystem maintainer ack/R-b before
> > actually asking him.
>
> Rob's review is enough for a DT binding, no need to wait for me. but
> FWIW:
>
> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>

Great, thanks.
> > Thanks,
> > Conor.
> >
> > > > Thanks,
> > > > Conor.
> > > >
> > > > On 14/02/2022 13:58, conor.dooley@xxxxxxxxxxxxx wrote:
> > > > > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > > > >
> > > > > Add device tree bindings for the real time clock on
> > > > > the Microchip PolarFire SoC.
> > > > >
> > > > > Signed-off-by: Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx>
> > > > > Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > > > > Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx>
> > > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > > > > ---
> > > > >     .../bindings/rtc/microchip,mfps-rtc.yaml      | 58 +++++++++++++++++++
> > > > >     1 file changed, 58 insertions(+)
> > > > >     create mode 100644 Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
> > > > > new file mode 100644
> > > > > index 000000000000..a2e984ea3553
> > > > > --- /dev/null
> > > > > +++ b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml
> > > > > @@ -0,0 +1,58 @@
> > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > > +%YAML 1.2
> > > > > +---
> > > > > +$id: http://devicetree.org/schemas/rtc/microchip,mfps-rtc.yaml#
> > > > > +
> > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > > +
> > > > > +title: Microchip PolarFire Soc (MPFS) RTC Device Tree Bindings
> > > > > +
> > > > > +allOf:
> > > > > +  - $ref: rtc.yaml#
> > > > > +
> > > > > +maintainers:
> > > > > +  - Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx>
> > > > > +  - Lewis Hanly <lewis.hanly@xxxxxxxxxxxxx>
> > > > > +
> > > > > +properties:
> > > > > +  compatible:
> > > > > +    enum:
> > > > > +      - microchip,mpfs-rtc
> > > > > +
> > > > > +  reg:
> > > > > +    maxItems: 1
> > > > > +
> > > > > +  interrupts:
> > > > > +    items:
> > > > > +      - description: |
> > > > > +          RTC_WAKEUP interrupt
> > > > > +      - description: |
> > > > > +          RTC_MATCH, asserted when the content of the Alarm register is equal
> > > > > +          to that of the RTC's count register.
> > > > > +
> > > > > +  clocks:
> > > > > +    maxItems: 1
> > > > > +
> > > > > +  clock-names:
> > > > > +    items:
> > > > > +      - const: rtc
> > > > > +
> > > > > +required:
> > > > > +  - compatible
> > > > > +  - reg
> > > > > +  - interrupts
> > > > > +  - clocks
> > > > > +  - clock-names
> > > > > +
> > > > > +additionalProperties: false
> > > > > +
> > > > > +examples:
> > > > > +  - |
> > > > > +    rtc@20124000 {
> > > > > +        compatible = "microchip,mpfs-rtc";
> > > > > +        reg = <0x20124000 0x1000>;
> > > > > +        clocks = <&clkcfg 21>;
> > > > > +        clock-names = "rtc";
> > > > > +        interrupts = <80>, <81>;
> > > > > +    };
> > > > > +...
> > >
> > > --
> > > Alexandre Belloni, co-owner and COO, Bootlin
> > > Embedded Linux and Kernel engineering
> > > https://bootlin.com