Re: [PATCH] Documentation/vm/page_owner.rst: fix commends

From: Randy Dunlap
Date: Wed Feb 23 2022 - 12:17:19 EST


Hi,

On 2/23/22 05:41, Yixuan Cao wrote:
> There are some commends that need to be fixed.
>
> Thanks for Shuah Khan's constructive suggestions.
> The commends have been fixed as follows.
>
> a. So, if you'd like to use it, you need
> to add "page_owner=on" into your boot cmdline.
>
> Here, "into" has been replaced with "to".
>
> b. ...page owner is disabled in runtime due to no
> enabling, boot option, runtime overhead is marginal.
>
> Here, "no" has been replaced with "not".
>
> Signed-off-by: Yixuan Cao <caoyixuan2019@xxxxxxxxxxxxxxxx>

The file changes look good.
The Subject and patch description should use "comments"
instead of "commends".

thanks.

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

> ---
> Documentation/vm/page_owner.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
> index 2b54e82b9fe1..aec1906976f4 100644
> --- a/Documentation/vm/page_owner.rst
> +++ b/Documentation/vm/page_owner.rst
> @@ -26,9 +26,9 @@ fragmentation statistics can be obtained through gfp flag information of
> each page. It is already implemented and activated if page owner is
> enabled. Other usages are more than welcome.
>
> -page owner is disabled in default. So, if you'd like to use it, you need
> -to add "page_owner=on" into your boot cmdline. If the kernel is built
> -with page owner and page owner is disabled in runtime due to no enabling
> +page owner is disabled by default. So, if you'd like to use it, you need
> +to add "page_owner=on" to your boot cmdline. If the kernel is built
> +with page owner and page owner is disabled in runtime due to not enabling
> boot option, runtime overhead is marginal. If disabled in runtime, it
> doesn't require memory to store owner information, so there is no runtime
> memory overhead. And, page owner inserts just two unlikely branches into

--
~Randy