Re: [PATCH] x86/mm/cpa: Generalize __set_memory_enc_pgtable()

From: Kirill A. Shutemov
Date: Wed Feb 23 2022 - 07:25:00 EST


On Wed, Feb 23, 2022 at 01:13:03PM +0100, Borislav Petkov wrote:
> On Wed, Feb 23, 2022 at 02:55:39PM +0300, Kirill A. Shutemov wrote:
> > This operation can fail for TDX. We need to be able to return error code
> > here:
> > /* Notify hypervisor that we have successfully set/clr encryption attribute. */
> > if (!ret)
> > ret = x86_platform.guest.enc_status_change_finish(addr, numpages, enc);
>
> bool to state failure/success or you need to return a specific value?

So far it is only success or failure. I used int and -EIO as failure.
bool is enough, but I don't see a reason not to use int.

--
Kirill A. Shutemov