Re: [PATCH] reiserfs: get rid of AOP_FLAG_CONT_EXPAND flag

[Jan Kara]

On Tue 22-02-22 13:38:19, Matthew Wilcox wrote:
> On Tue, Feb 22, 2022 at 11:27:27AM +0100, Jan Kara wrote:
> > On Mon 21-02-22 00:22:19, Edward Shishkin wrote:
> > > Signed-off-by: Edward Shishkin <edward.shishkin@xxxxxxxxx>
> > > ---
> > >  fs/reiserfs/inode.c | 16 +++++-----------
> > >  1 file changed, 5 insertions(+), 11 deletions(-)
> > 
> > Thanks! I have queued this patch into my tree.
> 
> I added the following commit message to it for my tree:
> 
> Author: Edward Shishkin <edward.shishkin@xxxxxxxxx>
> Date:   Mon Feb 21 00:22:19 2022 +0100
> 
>     reiserfs: Stop using AOP_FLAG_CONT_EXPAND flag
> 
>     We can simplify write_begin() and write_end() by handling the
>     cont_expand case in reiserfs_setattr().
> 
>     Signed-off-by: Edward Shishkin <edward.shishkin@xxxxxxxxx>
>     Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Yeah, I have written some changelog as well :) Something like:

    reiserfs: get rid of AOP_FLAG_CONT_EXPAND flag
    
    Remove usage of AOP_FLAG_CONT_EXPAND flag. Reiserfs is the only user of
    it and it is easy to avoid.
    
    Link: https://lore.kernel.org/r/20220220232219.1235-1-edward.shishkin@xxxxxxxxx
    Signed-off-by: Edward Shishkin <edward.shishkin@xxxxxxxxx>
    Signed-off-by: Jan Kara <jack@xxxxxxx>

> I don't object if it goes via your tree; I doubt I'll get the AOP_FLAG
> removal finished in time for the next merge window.

OK, I'll keep it in my tree then and push it to Linus for the merge window.

								Honza
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR