Re: [PATCH 3/4] ARM: at91: pm: add support for sama5d2 secure suspend

[Clément Léger]

Le Wed, 23 Feb 2022 17:15:44 +0800,
kernel test robot <lkp@xxxxxxxxx> a écrit :

>    arm-linux-gnueabi-ld: arch/arm/mach-at91/pm_secure.o: in function `sama5_pm_init':
> >> (.init.text+0x10c): multiple definition of `sama5_pm_init'; arch/arm/mach-at91/pm.o:(.init.text+0x1b58): first defined here  
>    arm-linux-gnueabi-ld: arch/arm/mach-at91/pm_secure.o: in function `sama5d2_pm_init':
> >> (.init.text+0x160): multiple definition of `sama5d2_pm_init'; arch/arm/mach-at91/pm.o:(.init.text+0x1c0c): first defined here  
>    arm-linux-gnueabi-ld: arch/arm/mach-at91/pm_secure.o: in function `at91_suspend_entering_slow_clock':
> >> (.text+0x0): multiple definition of `at91_suspend_entering_slow_clock'; arch/arm/mach-at91/pm.o:(.text+0x80): first defined here  
> 
> Kconfig warnings: (for reference only)
>    WARNING: unmet direct dependencies detected for ATMEL_PM
>    Depends on ARCH_AT91 && !ATMEL_SECURE_PM
>    Selected by
>    - SOC_SAMA7 && ARCH_AT91 && PM

Actually, using mutually exclusive option for ATMEL_PM and
ATMEL_SECURE_PM does not seems to fit this really well. I guess it
would be better to integrate secure PM handling inside existing PM.c
code.

-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com